Birmingham | ITP-Jan | Ahmad Roman Sanaye | Sprint 3 | Practice-tdd#1167
Birmingham | ITP-Jan | Ahmad Roman Sanaye | Sprint 3 | Practice-tdd#1167RomanSanaye wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
…; pass all test cases
RomanSanaye
added
the
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
I noticed some minor format inconsistency.
Have you installed the prettier VSCode extension and enabled "Format on save/paste" on VSCode, as recommended in
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md
?
If you have enabled "Format on save" but it is not working, it is likely that you haven't assign a formatter for JS file. This could happen if you have zero or multiple extensions that can format .js file.
If you have installed "Prettier" extension. To assign it as the formatter of JS code, you can try:
- Use "Format document" to format the JS file. Sometimes, VSCode will ask you to choose a formatter, and you can manually select "Prettier".
- Edit
settings.jsonand set Prettier as the default formatter for JS.
See: https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode
| if (numberOfChar === 0) { | ||
| return `0 ${findCharacter} found.` | ||
| } |
There was a problem hiding this comment.
The function is expected to return an integer number. Returning a string would make the function difficult to use because the caller would need to check the data type of the return value.
| expect(getOrdinalNumber(33)).toEqual("33rd"); | ||
| expect(getOrdinalNumber(333)).toEqual("333rd"); | ||
| }); | ||
| test("should append 'th' for numbers ending with 4 and more than 4", () => { |
There was a problem hiding this comment.
... ending with 4-9, 0 might be more concise.
| // When the repeatStr function is called with these inputs, | ||
| // Then it should return the original `str` without repetition. | ||
|
|
||
| test("should print the original string", () => { |
There was a problem hiding this comment.
"print" may suggest the function should output the string.
| // When the repeatStr function is called with these inputs, | ||
| // Then it should return an empty string. | ||
|
|
||
| test("should return an empty string", () => { |
There was a problem hiding this comment.
You could probably make this description more informative by including the when ... part.
cjyuan
added
Reviewed
2 participants
Self checklist
Changelist
Implemented the following functions:
Each function handles the required cases and passes all Jest test cases, including edge cases (positive, zero, and negative values where applicable).
All tests are passing successfully.